fix(entgql): check fields RType for Map and use Map scalar if possible #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, @tankbusta 🙏🏻 Can you add a simple test for this? A field in one of these schemas: /~https://github.com/ent/contrib/tree/master/entgql/internal/todo/ent/schema |
tankbusta
force-pushed
the
fix/entgql_json_type
branch
from
cce019e to
21984a2
Compare
giautm
reviewed
Mar 24, 2023
| @@ -773,6 +773,13 @@ func (e *schemaGenerator) mapScalar(gqlType string, f *gen.Field, ant *Annotatio | |||
| case "[]string": | |||
| scalar = "[String!]" | |||
| } | |||
| case reflect.Map: | |||
| if f.Type.RType.Ident == "map[string]interface {}" { | |||
There was a problem hiding this comment.
the spacing between interface and {} really weird. But the test passed
There was a problem hiding this comment.
Yeah, I was confused when I saw that at first but I think it's just how the reflect package identifies interface{}. You can see the same format in some of their tests: /~https://github.com/golang/go/blob/master/src/reflect/all_test.go#L713
Signed-off-by: Giau. Tran Minh <hello@giautm.dev>
giautm
force-pushed
the
fix/entgql_json_type
branch
from
b52fa06 to
5323245
Compare
|
Thank @tankbusta for your contribution. Good to see your here again, <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create an entity with a JSON field...
You will get an error when running code generation
You can resolve this today by adding the annotation
entgql.Type("Map")but I didn't see any mention that this was required so I made the code a little bit smarter by checking if it's ofmap[string]interface {}and using the built-inMapscalar. If you do not set this, the error is made smarter by recommending that you setentgql.Type.